Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Connect button now displays correct copy #127291

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

sphilipse
Copy link
Member

Summary

This shows 'Connect' instead of 'Connect another' on the Configured Sources list if there are no connected sources.

@sphilipse sphilipse requested a review from a team as a code owner March 9, 2022 15:18
@sphilipse sphilipse added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 9, 2022
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

@sphilipse sphilipse enabled auto-merge (squash) March 9, 2022 15:55
@sphilipse
Copy link
Member Author

Looks like Kibana's CI is just broken right now :/

image

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@sphilipse sphilipse merged commit 0ba204b into elastic:main Mar 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB +135.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants